1 2012-06-24T00:03:37 *** dreimark3
2 2012-06-24T01:09:00 *** spy
3 2012-06-24T01:20:25 <ThomasWaldmann> xiaq: you broke anywikidraw (adraw) modify
4 2012-06-24T01:21:17 <ThomasWaldmann> just save some drawing and then modify it, you'll get a fresh drawing canvas, not the drawing as it was before
5 2012-06-24T01:22:59 <ThomasWaldmann> xiaq: issue filed on your tracker
6 2012-06-24T01:42:46 <ThomasWaldmann> jek: when you have some time, look at https://bitbucket.org/xiaq/moin-2.0 and his forms work
7 2012-06-24T04:06:01 *** MattMaker
8 2012-06-24T05:40:54 <xiaq> ThomasWaldmann: ah, sorry didn't do a thorough test
9 2012-06-24T05:43:33 <xiaq> ThomasWaldmann: issue closed, pull request resent
10 2012-06-24T05:55:47 *** MattMaker
11 2012-06-24T08:08:27 *** jaiditya
12 2012-06-24T11:03:35 *** jaiditya
13 2012-06-24T11:50:09 *** spy
14 2012-06-24T12:10:07 <ThomasWaldmann> moin
15 2012-06-24T12:13:21 <ThomasWaldmann> xiaq: seems like except: got you :)
16 2012-06-24T12:21:31 <ThomasWaldmann> xiaq: btw, drawing_exists looks strange.
17 2012-06-24T12:22:24 <ThomasWaldmann> seems like a misnomer as you put the drawing name in there
18 2012-06-24T12:22:57 <ThomasWaldmann> but if it does not exist, you assign False
19 2012-06-24T12:23:39 * ThomasWaldmann would rather use drawing and either the name or None
20 2012-06-24T12:31:14 <ThomasWaldmann> hmm, was the same before, so the bad naming/types is not from you
21 2012-06-24T12:34:07 <xiaq> ThomasWaldmann: yeah
22 2012-06-24T12:38:05 <ThomasWaldmann> hmm, gettings lots of pep8 fails
23 2012-06-24T12:38:10 <ThomasWaldmann> -s
24 2012-06-24T12:40:29 <ThomasWaldmann> seems like there were incompatible changes after pep8==1.2
25 2012-06-24T12:41:27 <ThomasWaldmann> xiaq: any feedback from jek or other #discorporate folks yet?
26 2012-06-24T12:56:59 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1391:339668f8ad06 2.0/MoinMoin/ (apps/frontend/views.py items/__init__.py): refactor of apps/frontend/views.py and items/__init__.py modules
27 2012-06-24T12:57:00 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1392:7a2ee6335ea9 2.0/ (.hgignore MoinMoin/items/__init__.py): merge
28 2012-06-24T12:57:00 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1393:0f0932809e1e 2.0/MoinMoin/items/__init__.py: Fix broken AnyWikiDraw.
29 2012-06-24T12:57:10 <ThomasWaldmann> xiaq: ^^
30 2012-06-24T12:59:09 <xiaq> jek said my patch set was good, i'll ask him how he thinks about the "?layout" stuff
31 2012-06-24T12:59:14 <xiaq> s/\?//
32 2012-06-24T12:59:37 <xiaq> ThomasWaldmann: aha, got notification email about pull request being accepted :)
33 2012-06-24T13:02:29 <ThomasWaldmann> ok, guess i try switching over to pytest-pep8 now
34 2012-06-24T13:04:06 <ThomasWaldmann> the features i suggested 1-2 weeks ago are already implemented and released :)
35 2012-06-24T14:12:48 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1394:d568defb6845 2.0/ (setup.cfg setup.py MoinMoin/_tests/test_sourcecode.py): remove test_sourcecode, replace it by pytest-pep8
36 2012-06-24T14:13:29 <ThomasWaldmann> ^^ requires (as usual when requirements change): pip install -e .
37 2012-06-24T14:23:32 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1395:249b7900fe28 2.0/ (contrib/wsgi/proxy.py setup.cfg setup.py wikiconfig.py): fix some pep8 issues, remove the fixed files from pep8 checker's exlusion list
38 2012-06-24T14:23:45 <xiaq> ThomasWaldmann: hm, how do i run pep8 test now?
39 2012-06-24T14:24:03 <xiaq> previously i do `py.test -k source`
40 2012-06-24T14:24:37 <ThomasWaldmann> py.test --pep8
41 2012-06-24T14:24:57 <xiaq> ThomasWaldmann: ah, got it :)
42 2012-06-24T14:25:03 <ThomasWaldmann> or, if you ONLY want to check for pep8, then do: py.test --pep8 -k pep8
43 2012-06-24T14:25:40 <xiaq> ThomasWaldmann: got it
44 2012-06-24T14:26:49 <xiaq> aha, with pytest-pep8 i no longer have that annoying traceback pointing to test_sourcecode.py instead of code being checked
45 2012-06-24T14:29:17 <xiaq> hm MoinMoin/util/md5crypt.py has failing pep8 tests
46 2012-06-24T14:31:05 <dreimark> moin
47 2012-06-24T14:40:44 <ThomasWaldmann> xiaq: i am still fixing some pep8 related stuff, just wait a minute :)
48 2012-06-24T14:40:57 <ThomasWaldmann> and see the comments in setup.cfg
49 2012-06-24T14:42:12 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1396:86e998d808e7 2.0/ (7 files in 6 dirs): pep8 whitespace fixes
50 2012-06-24T14:49:09 *** kanha
51 2012-06-24T14:50:05 *** kanha_
52 2012-06-24T15:16:00 *** dwcramer
53 2012-06-24T15:40:10 *** dwcramer
54 2012-06-24T16:16:44 *** dwcramer
55 2012-06-24T16:22:36 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1397:4ac437141bbe 2.0/ (359 files in 63 dirs): make file ends pep8 compliant (== exactly 1 LF at EOF)
56 2012-06-24T16:22:36 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1398:f7604105f64a 2.0/contrib/pep8/DeleteTrailingSpaces.py:
57 2012-06-24T16:22:37 <CIA-54> DeleteTrailingSpaces.py: work conforming to pep8, add starting_dir commandline param
58 2012-06-24T16:22:37 <CIA-54> make sure that there is exactly one linefeed at file end
59 2012-06-24T16:22:37 <CIA-54> starting_dir can now be given on the commandline as first argument
60 2012-06-24T16:22:37 <CIA-54> some cosmetic changes / refactorings
61 2012-06-24T16:23:47 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1399:9b2e4fa167f7 2.0/setup.cfg: let pytest-pep8 check the file endings for trailing lines
62 2012-06-24T16:28:38 *** RogerHaase
63 2012-06-24T16:41:06 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1400:89110a0edced 2.0/Makefile: remove tabnanny from Makefile, the pep8 checker checks this already
64 2012-06-24T16:41:06 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1401:29e980721a6b 2.0/ (Makefile docs/devel/development.rst): make test (new make target plus testing docs update)
65 2012-06-24T17:59:07 <ThomasWaldmann> waldi: jaiditya put up a lot of changesets
66 2012-06-24T18:20:03 *** RogerHaase
67 2012-06-24T19:12:13 * dreimark looks at the jaiditya repo
68 2012-06-24T19:15:02 <ThomasWaldmann> dreimark: foobar is getting better, i am just filing some issues to his bb issue tracker
69 2012-06-24T19:18:13 <ThomasWaldmann> dreimark: http://localhost:8080/Home/Test2 < if you look there, would you think you could click on that white "Home" or "Test2"?
70 2012-06-24T19:19:48 * dreimark adds also some issues
71 2012-06-24T19:20:00 * dreimark trird
72 2012-06-24T19:20:49 <dreimark> ThomasWaldmann: no because it is white, similar to all the topics "Links, Trail..."
73 2012-06-24T19:21:04 <dreimark> I would not expect that it is clickable
74 2012-06-24T19:22:41 <dreimark> two solutions now, make the others also clickable or fix the "Home" or "Test2" color to link color
75 2012-06-24T19:23:37 <dreimark> ThomasWaldmann: we have translation issues with the sidebars
76 2012-06-24T19:23:44 <dreimark> when words too long
77 2012-06-24T19:32:09 <ThomasWaldmann> otoh, those "panel headers" are all white, so making it blue would somehow create another issue (and maybe also look a bit ugly)
78 2012-06-24T20:40:19 <dreimark> bbl
79 2012-06-24T20:40:39 <dreimark> nice theme, just some small issues
80 2012-06-24T21:42:53 *** dreimark2
81 2012-06-24T21:45:26 *** dwcramer
82 2012-06-24T22:06:11 *** dreimark2
83 2012-06-24T22:30:54 *** dwcramer
84 2012-06-24T23:13:08 *** dwcramer
85 2012-06-24T23:37:46 *** sudo_dirk
86 2012-06-24T23:40:23 *** sudo_dirk1
87 2012-06-24T23:43:04 *** MattMaker
88 2012-06-24T23:50:25 *** MattMaker
89